Merge pull request #642 from qiboteam/fix_punchout

Fixing punchout plots
qiboteam · Nov 24, 2023 · 73ff1eb · 73ff1eb
2 parents e127bf5 + 9b2f204
commit 73ff1eb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/src/qibocal/protocols/characterization/resonator_punchout.py b/src/qibocal/protocols/characterization/resonator_punchout.py
@@ -198,10 +198,7 @@ def _plot(data: ResonatorPunchoutData, qubit, fit: ResonatorPunchoutResults = No
         row=1,
         col=1,
     )
-    fig.update_xaxes(title_text="Frequency [GHz]", row=1, col=1)
-    fig.update_xaxes(title_text="Frequency [GHz]", row=1, col=2)
-    fig.update_yaxes(title_text="Amplitude [a.u.]", row=1, col=1)
-    fig.update_yaxes(title_text="Amplitude [a.u.]", row=1, col=2)
+
     fig.add_trace(
         go.Heatmap(
             x=frequencies,
@@ -217,7 +214,7 @@ def _plot(data: ResonatorPunchoutData, qubit, fit: ResonatorPunchoutResults = No
         fig.add_trace(
             go.Scatter(
                 x=[
-                    fit.readout_frequency[qubit],
+                    fit.readout_frequency[qubit] * HZ_TO_GHZ,
                 ],
                 y=[
                     fit.readout_amplitude[qubit],
@@ -228,6 +225,8 @@ def _plot(data: ResonatorPunchoutData, qubit, fit: ResonatorPunchoutResults = No
                     color="gray",
                     symbol="circle",
                 ),
+                name="Estimated readout point",
+                showlegend=True,
             )
         )
         fitting_report = table_html(
@@ -247,9 +246,14 @@ def _plot(data: ResonatorPunchoutData, qubit, fit: ResonatorPunchoutResults = No
         )
 
     fig.update_layout(
-        showlegend=False,
+        showlegend=True,
+        legend=dict(orientation="h"),
     )
 
+    fig.update_xaxes(title_text="Frequency [GHz]", row=1, col=1)
+    fig.update_xaxes(title_text="Frequency [GHz]", row=1, col=2)
+    fig.update_yaxes(title_text="Amplitude [a.u.]", row=1, col=1)
+
     figures.append(fig)
 
     return figures, fitting_report

diff --git a/src/qibocal/protocols/characterization/resonator_punchout_attenuation.py b/src/qibocal/protocols/characterization/resonator_punchout_attenuation.py
@@ -209,13 +209,12 @@ def _plot(
         col=2,
     )
     fig.update_xaxes(title_text="Frequency [GHz]", row=1, col=2)
-    fig.update_yaxes(title_text="Attenuation [dB]", row=1, col=2)
 
     if fit is not None:
         fig.add_trace(
             go.Scatter(
                 x=[
-                    fit.readout_frequency[qubit],
+                    fit.readout_frequency[qubit] * HZ_TO_GHZ,
                 ],
                 y=[
                     fit.readout_attenuation[qubit],
@@ -226,6 +225,8 @@ def _plot(
                     color="gray",
                     symbol="circle",
                 ),
+                name="Estimated readout point",
+                showlegend=True,
             )
         )
         fitting_report = table_html(
@@ -244,7 +245,8 @@ def _plot(
             )
         )
     fig.update_layout(
-        showlegend=False,
+        showlegend=True,
+        legend=dict(orientation="h"),
     )
 
     figures.append(fig)