conditional and virtual phase experiment improvements

[hay-k]

• Remove parameters flux_pulse_amplitude and flux_pulse_duration from the experiment correct_virtual_z_phases. I think they are not usefull - nobody is going to manually try out various combinations of these parameters to find a good one. There is the optimize_two_qubit_gate for this type of task.
  • BTW, flux_pulse_duration was not even used, it was ignored and always the flux pulse duration from platform was used.
• Get rid of the amplitude argument of the create_sequence function (as a consequence of the change in the above point). Rename the duration argument to flux_pulse_max_duration - this is needed for the optimize routine to make sure there is enough room for the duration sweep, and the flux pulse does not overlap with readout (this is different from dt, which is just a constant offset, not dependent on values used for sweep).
• Change the return content of the create_sequence function. Now it return the sequence, reference to the flux pulse, reference to the theta pulse.
• Move the code for fitting a sinusoid to a separate function, so that it is reused instead of duplicated.
• And, the reason all of this started, the phase difference between two sinusoids is now calculated in a manner, that it is normalized in the [0, pi] range, and does not cause large jumps because of angle fluctuations close to boundary values (0 and pi).:
  • before:
  • after:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (8521bd4) to head (2026610).
Report is 20 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   97.32%   97.33%   +0.01%     
==========================================
  Files         124      124              
  Lines        9893     9881      -12     
==========================================
- Hits         9628     9618      -10     
+ Misses        265      263       -2     

Flag	Coverage Δ
unittests	97.33% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ibocal/protocols/two_qubit_interaction/optimize.py	97.68% <100.00%> (-0.03%)	⬇️
...rotocols/two_qubit_interaction/virtual_z_phases.py	95.91% <100.00%> (+0.37%)	⬆️
...s/two_qubit_interaction/virtual_z_phases_signal.py	100.00% <ø> (ø)

... and 2 files with indirect coverage changes

[andrea-pasquale]

Thank you @hay-k