Interleaved RB #864

Jacfomg · 2024-05-21T14:04:58Z

1st draft for the interleaved RB. It seems to work but it needs qiboteam/qibolab#906

Checklist:

Reviewers confirm new code works as expected.
Tests are passing.
Coverage does not decrease.
Documentation is updated.
Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
- Qibo: master
- Qibolab: main
- Qibolab_platforms_qrc: main

codecov · 2024-05-21T14:13:13Z

Codecov Report

Attention: Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.50%. Comparing base (f348523) to head (667e954).
Report is 34 commits behind head on main.

Files	Patch %	Lines
...qibocal/protocols/randomized_benchmarking/utils.py	95.23%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
+ Coverage   97.48%   97.50%   +0.02%     
==========================================
  Files         122      123       +1     
  Lines        9650     9701      +51     
==========================================
+ Hits         9407     9459      +52     
+ Misses        243      242       -1

Flag	Coverage Δ
unittests	`97.50% <98.41%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/qibocal/protocols/__init__.py	`100.00% <100.00%> (ø)`
...l/protocols/randomized_benchmarking/filtered_rb.py	`96.87% <100.00%> (ø)`
...l/protocols/randomized_benchmarking/standard_rb.py	`98.59% <100.00%> (ø)`
...rotocols/randomized_benchmarking/standard_rb_2q.py	`100.00% <100.00%> (ø)`
...ls/randomized_benchmarking/standard_rb_2q_inter.py	`100.00% <100.00%> (ø)`
...qibocal/protocols/randomized_benchmarking/utils.py	`95.80% <95.23%> (-0.19%)`	⬇️

... and 2 files with indirect coverage changes

for more information, see https://pre-commit.ci

… into 2q_rb_interleaved

for more information, see https://pre-commit.ci

… into 2q_rb_interleaved

src/qibocal/protocols/randomized_benchmarking/standard_rb_2q_inter.py

Edoardo-Pedicillo · 2024-05-30T08:12:03Z

src/qibocal/protocols/randomized_benchmarking/standard_rb_2q_inter.py

+    qubits = data.pairs
+    results = fit(qubits, data)
+
+    # FIXME: I can only get the data.fidelity if there is an acquisition step


In which cases you don't have an acquisition step?

when you just want to plot becuase you ran a new 2qRB but not interleaved for example

I don't understand the problem here. Either you run a 2qRb or a 2qInterleavedR, no?

Edoardo-Pedicillo · 2024-05-30T08:16:30Z

src/qibocal/protocols/randomized_benchmarking/utils.py

        new_circuit = Circuit(nqubits)
        if nqubits == 1:
            new_circuit.add(new_layer)
        elif nqubits == 2:
            for gate in new_layer:
                new_circuit.add(gate)
-
-        random_indexes.append(random_index)
+            # FIXME: General interleave


Raise a not supported error instead of a FIXME

Edoardo-Pedicillo · 2024-05-30T08:23:13Z

src/qibocal/protocols/randomized_benchmarking/utils.py

+                interleaved_clifford = rb_gen.two_qubit_cliffords["13"]
+                interleaved_clifford_gate = clifford2gates(interleaved_clifford)
+                new_circuit.add(interleaved_clifford_gate)
+                random_indexes.append("13")


why not just create the CZ with Qibo ? Since the 2qRB files are merely one possibility, let's make every effort to separate the Qibocal library from them.

Indeed, here it should be better to create the CZ with Qibo

for more information, see https://pre-commit.ci

… into 2q_rb_interleaved

Edoardo-Pedicillo

Thank @Jacfomg, just small comments

src/qibocal/protocols/randomized_benchmarking/standard_rb_2q_inter.py

src/qibocal/protocols/randomized_benchmarking/utils.py

…nter.py Co-authored-by: Edoardo Pedicillo <[email protected]>

… into 2q_rb_interleaved

Edoardo-Pedicillo

LGTM, please fix the conflicts

andrea-pasquale

Thanks @Jacfomg, mostly it looks good to me.
There are some conversations that were resolved but the comments from the reviewer were not addressed.
Once we address the comment we can merge.
It would also nice to run a very short RB on hardware. You can use for example: qiboteam/qibolab_platforms_qrc#160

andrea-pasquale · 2024-08-01T14:56:54Z

src/qibocal/protocols/randomized_benchmarking/standard_rb_2q_inter.py

+    qubits = data.pairs
+    results = fit(qubits, data)
+
+    # FIXME: I can only get the data.fidelity if there is an acquisition step


I don't understand the problem here. Either you run a 2qRb or a 2qInterleavedR, no?

src/qibocal/protocols/randomized_benchmarking/utils.py

andrea-pasquale · 2024-08-01T14:58:48Z

src/qibocal/protocols/randomized_benchmarking/utils.py

        new_circuit = Circuit(nqubits)
        if nqubits == 1:
            new_circuit.add(new_layer)
        elif nqubits == 2:
            for gate in new_layer:
                new_circuit.add(gate)
-
-        random_indexes.append(random_index)
+            # FIXME: General interleave


andrea-pasquale · 2024-08-01T14:59:10Z

src/qibocal/protocols/randomized_benchmarking/utils.py

+                interleaved_clifford = rb_gen.two_qubit_cliffords["13"]
+                interleaved_clifford_gate = clifford2gates(interleaved_clifford)
+                new_circuit.add(interleaved_clifford_gate)
+                random_indexes.append("13")


Indeed, here it should be better to create the CZ with Qibo

Jacfomg · 2024-08-07T08:11:14Z

Indeed, here it should be better to create the CZ with Qibo

Why, it would be the same. And we keep everything safe in case Qibo does something different for another gate.,

Jacfomg · 2024-08-07T08:19:05Z

Also, for the general interleave what would be the interface for which clifford to interleave, a number from 0 to 11000 as a parameter ?

andrea-pasquale · 2024-08-12T04:21:37Z

Also, for the general interleave what would be the interface for which clifford to interleave, a number from 0 to 11000 as a parameter ?

If the number is documented properly yes.

andrea-pasquale · 2024-08-12T04:22:23Z

Also, for the general interleave what would be the interface for which clifford to interleave, a number from 0 to 11000 as a parameter ?

If the number is documented properly yes, generally the user could also pass a matrix and we can verify whether it is in the clifford group, right?
The problem with indices in general is that we are not following any specific convention, so running an interleaved RB on gate 123 doesn't tell much.

andrea-pasquale

Thanks for the updates @Jacfomg.
I would like to see a short run on hardware to check that everything is working properly before merging.

Jacfomg added 2 commits May 21, 2024 18:03

feat: 1st draft for the interleaved

a3e045e

fix: tests

b8ccf6b

Jacfomg and others added 7 commits May 21, 2024 18:23

fix: tests

67573ab

Merge branch '2q_RB' into 2q_rb_interleaved

64ca47b

fix: forgot function

a87f7b5

wip: proper interleave

67b9dc7

Merge branch '2q_RB' into 2q_rb_interleaved

301df90

feat: Add interleave parameter

2d037af

[pre-commit.ci] auto fixes from pre-commit.com hooks

d0b8a47

for more information, see https://pre-commit.ci

Jacfomg requested review from Edoardo-Pedicillo and andrea-pasquale May 22, 2024 13:35

Jacfomg marked this pull request as ready for review May 22, 2024 13:35

Jacfomg and others added 5 commits May 22, 2024 17:37

fix: remove unused

a636f88

Merge branch '2q_rb_interleaved' of https://github.com/qiboteam/qibocal…

31642bf

… into 2q_rb_interleaved

[pre-commit.ci] auto fixes from pre-commit.com hooks

d363455

for more information, see https://pre-commit.ci

fix: tmp_path on tests

d6ba16f

Merge branch '2q_rb_interleaved' of https://github.com/qiboteam/qibocal…

2de76b3

… into 2q_rb_interleaved

Edoardo-Pedicillo requested changes May 30, 2024

View reviewed changes

andrea-pasquale added the calibration label Jun 3, 2024

Base automatically changed from 2q_RB to main June 19, 2024 09:05

Jacfomg and others added 6 commits July 23, 2024 10:00

Merge branch 'main' into 2q_rb_interleaved

933b51e

[pre-commit.ci] auto fixes from pre-commit.com hooks

3c233f4

for more information, see https://pre-commit.ci

fix: platform patch

4224415

Merge branch '2q_rb_interleaved' of https://github.com/qiboteam/qibocal…

5ba40d9

… into 2q_rb_interleaved

fix: argument order

29cc3dc

feat: fix tests and interleaved gate for CZ

9c7d1b1

Jacfomg requested a review from Edoardo-Pedicillo July 23, 2024 07:13

Edoardo-Pedicillo reviewed Jul 25, 2024

View reviewed changes

Update src/qibocal/protocols/randomized_benchmarking/standard_rb_2q_i…

2a79e37

…nter.py Co-authored-by: Edoardo Pedicillo <[email protected]>

Jacfomg and others added 3 commits July 26, 2024 10:31

Update src/qibocal/protocols/randomized_benchmarking/standard_rb_2q_i…

8846702

…nter.py Co-authored-by: Edoardo Pedicillo <[email protected]>

fix: docs

30468ee

Merge branch '2q_rb_interleaved' of https://github.com/qiboteam/qibocal…

962c951

… into 2q_rb_interleaved

Jacfomg requested a review from Edoardo-Pedicillo July 26, 2024 07:12

Edoardo-Pedicillo approved these changes Jul 29, 2024

View reviewed changes

Jacfomg added 2 commits July 29, 2024 13:00

Merge branch 'main' into 2q_rb_interleaved

c3af513

fix: conflicts

b7af56e

andrea-pasquale added this to the Qibocal 0.0.11 milestone Jul 31, 2024

andrea-pasquale requested changes Aug 1, 2024

View reviewed changes

Jacfomg added 2 commits August 7, 2024 12:14

fix: comments

79bd4dd

fix: remove comment

fd141d8

Merge branch 'main' into 2q_rb_interleaved

a0c207d

andrea-pasquale reviewed Aug 12, 2024

View reviewed changes

andrea-pasquale added 2 commits August 14, 2024 16:27

fix: Minor fixes

0aa6469

Merge branch 'main' into 2q_rb_interleaved

c03b4a9

andrea-pasquale approved these changes Aug 14, 2024

View reviewed changes

fix: Fix dummy tests

667e954

andrea-pasquale added this pull request to the merge queue Aug 14, 2024

Merged via the queue into main with commit 4007e14 Aug 14, 2024
21 checks passed

andrea-pasquale deleted the 2q_rb_interleaved branch August 14, 2024 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interleaved RB #864

Interleaved RB #864

Jacfomg commented May 21, 2024 •

edited

Loading

codecov bot commented May 21, 2024 •

edited

Loading

Edoardo-Pedicillo May 30, 2024

Jacfomg Jul 23, 2024

andrea-pasquale Aug 1, 2024

Edoardo-Pedicillo May 30, 2024

andrea-pasquale Aug 1, 2024

Edoardo-Pedicillo May 30, 2024

andrea-pasquale Aug 1, 2024

Edoardo-Pedicillo left a comment

Edoardo-Pedicillo left a comment

andrea-pasquale left a comment

andrea-pasquale Aug 1, 2024

andrea-pasquale Aug 1, 2024

andrea-pasquale Aug 1, 2024

Jacfomg commented Aug 7, 2024

Jacfomg commented Aug 7, 2024

andrea-pasquale commented Aug 12, 2024

andrea-pasquale commented Aug 12, 2024 •

edited

Loading

andrea-pasquale left a comment

Interleaved RB #864

Interleaved RB #864

Conversation

Jacfomg commented May 21, 2024 • edited Loading

codecov bot commented May 21, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Edoardo-Pedicillo left a comment

Choose a reason for hiding this comment

Edoardo-Pedicillo left a comment

Choose a reason for hiding this comment

andrea-pasquale left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jacfomg commented Aug 7, 2024

Jacfomg commented Aug 7, 2024

andrea-pasquale commented Aug 12, 2024

andrea-pasquale commented Aug 12, 2024 • edited Loading

andrea-pasquale left a comment

Choose a reason for hiding this comment

Jacfomg commented May 21, 2024 •

edited

Loading

codecov bot commented May 21, 2024 •

edited

Loading

andrea-pasquale commented Aug 12, 2024 •

edited

Loading