-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rb_correction_qua #960
rb_correction_qua #960
Conversation
To be more explicit as an example and template
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some comments just for the script
runcards/rb_correction_qua.py
Outdated
biases = np.arange(-0.2, 0.1, 0.01) | ||
"bias points to sweep" | ||
|
||
# Flipping | ||
nflips_max = 200 | ||
"""Maximum number of flips ([RX(pi) - RX(pi)] sequences). """ | ||
nflips_step = 10 | ||
"""Flip step.""" | ||
|
||
# Ramsey signal | ||
detuning = 3_000_000 | ||
"""Frequency detuning [Hz].""" | ||
delay_between_pulses_start = 16 | ||
"""Initial delay between RX(pi/2) pulses in ns.""" | ||
delay_between_pulses_end = 5_000 | ||
"""Final delay between RX(pi/2) pulses in ns.""" | ||
delay_between_pulses_step = 200 | ||
"""Step delay between RX(pi/2) pulses in ns.""" | ||
|
||
# Std Rb Ondevice Parameters | ||
num_of_sequences: int = 100 | ||
max_circuit_depth: int = 250 | ||
"Maximum circuit depth" | ||
delta_clifford: int = 50 | ||
"Play each sequence with a depth step equals to delta_clifford" | ||
seed: Optional[int] = 1234 | ||
"Pseudo-random number generator seed" | ||
n_avg: int = 128 | ||
"Number of averaging loops for each random sequence" | ||
save_sequences: bool = True | ||
apply_inverse: bool = True | ||
state_discrimination: bool = True | ||
"Flag to enable state discrimination if the readout has been calibrated (rotated blobs and threshold)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If those parameters are only used once perhaps I would just used directly during the protocol calls instead of adding 30 lines of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was cleaner to change them there than to go aorund looking for them
@Jacfomg I can tell you, it is not xD |
Someone should make an issue for this XD |
I did it the other way around, it should be fine too I hope |
As a temporary solution, I'd say it's definitely fine. I will try to merge #949 asap, at which point I will rebase #959, and you could rebase your branch there.
Unfortunately, they do not accept issues :P |
09ac57a
to
5683fe4
Compare
5683fe4
to
40153aa
Compare
40153aa
to
970776b
Compare
Closing in favor of #975 |
I dont know how to point this to two branches or if it's even possible so I merge rb_qua branch here
It needs #959 to be merged
Checklist:
master
main
main