Improvements to expectation_from_samples code #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually want to have some shot allocation for each term in the Hamiltonian Currently, the code is s.t. `n_shots` is allocated for every single term in the Hamiltonian
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 12 +1
Lines 433 494 +61
=========================================
+ Hits 433 494 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For a uniform distribution of shots
chmwzc
added
enhancement
- Move code and functions that aim to reduce and optimize the measurement cost into a new file (`optimization.py`) - `expectation.py` is now more focused: Only code for obtaining the Hamiltonian expectation value left in there
np.array.as_type(int) truncates the array, so there shouldn't be a need to handle the case if too many shots were allocated...? - Note: Was observed quite long ago in local testing of an earlier version of code, but don't remember how I got it? - Might be that the changes to the earlier code removed the possibility of this happening?
Came about due to working on the ucc_ansatz and mol-updates branches separately
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 12 +1
Lines 433 495 +62
=========================================
+ Hits 433 495 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
damarkian
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
from_samples=Truein ourexpectationfunction,n_shotsis effectively allocated to each and every term in the Hamiltonian.This pull request aims to improve upon this by adding the functionality to manually allocate shots to the individual terms in the Hamiltonian.
Note: This should (hopefully) allow the implementation of some measurement reduction schemes as well...? But that's probably beyond the scope of this pull request.
(25 Jan edit): Code and tests are tentatively done, left with documentation