Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial sketch #3

Open
wants to merge 75 commits into
base: main
Choose a base branch
from
Open

Initial sketch #3

wants to merge 75 commits into from

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented May 30, 2023

  • insert in collection
    • start testing with single collection (e.g. platform.QPU)
    • always insert many
  • insert in database bundle
    • this will be the "runcard" mode, so with a single runcard, that will multiple collections with potentially multiple documents
    • the layout will be at the level of the DB enum (e.g. Platform)
  • read a record (given an ID)
    • in CLI (dump to stdout or file)
    • in Python (returning suitable object)
  • read a bundle

@@ -0,0 +1,24 @@
"""QPU specs and calibration."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to have these objects here or in qibolab? Because at the end these are the pieces we need to put together a Platform, so I am not sure if it makes sense to have them both here and also in qibolab.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I need them, because I have to specify the collections (tables), but I don't want to have a Qibolab dependency.

In the end, Qibolab will make use of this DB, so it will receive objects from here (same Qibocal).

However, to which level these objects are enough for Qibolab and Qibocal I'm not sure. They will not provide any API, just the data. Thus, all the methods and domain logic will be specific to the other packages (in principle you might consider to have wrappers, and use these in Qibolab as well to hold data).

pass


class InstrumentCalibration:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, this could be exactly the object I was trying to describe in qiboteam/qibolab_platforms_qrc#5 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I had already written it when I was reading your comment :P
(it's there since yesterday)

@alecandido alecandido marked this pull request as ready for review June 3, 2023 22:47
This was linked to issues Jun 4, 2023
@scarrazza scarrazza self-requested a review June 7, 2023 09:31
@alecandido alecandido requested a review from stavros11 June 7, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read API Get variables from environment
2 participants