-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial sketch #3
base: main
Are you sure you want to change the base?
Conversation
Caused by not-so-clear Poetry CLI
src/qibodb/dbs/platform/qpu.py
Outdated
@@ -0,0 +1,24 @@ | |||
"""QPU specs and calibration.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we planning to have these objects here or in qibolab? Because at the end these are the pieces we need to put together a Platform
, so I am not sure if it makes sense to have them both here and also in qibolab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I need them, because I have to specify the collections (tables), but I don't want to have a Qibolab dependency.
In the end, Qibolab will make use of this DB, so it will receive objects from here (same Qibocal).
However, to which level these objects are enough for Qibolab and Qibocal I'm not sure. They will not provide any API, just the data. Thus, all the methods and domain logic will be specific to the other packages (in principle you might consider to have wrappers, and use these in Qibolab as well to hold data).
pass | ||
|
||
|
||
class InstrumentCalibration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, this could be exactly the object I was trying to describe in qiboteam/qibolab_platforms_qrc#5 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I had already written it when I was reading your comment :P
(it's there since yesterday)
Incompatible with configs
Where relevant
Only used at runtime
With some opinionated updates
platform.QPU
)databasebundlePlatform
)