Skip to content

Commit

Permalink
fix: Comment pulse type in Qblox
Browse files Browse the repository at this point in the history
This is a terrible fix, it's not even a hint about how to solve the problem, but Qblox is scheduled for rewriting anyhow, so it's not worth to anything else
  • Loading branch information
alecandido committed Aug 6, 2024
1 parent f9a511f commit 323c6e3
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 9 deletions.
4 changes: 3 additions & 1 deletion src/qibolab/instruments/qblox/cluster_qcm_bb.py
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,9 @@ def process_pulse_sequence(
and pulses[n].sweeper.type == QbloxSweeperType.duration
):
RI = pulses[n].sweeper.register
if pulses[n].type == PulseType.FLUX:
# FIXME:
# if pulses[n].type == PulseType.FLUX:
if True:
RQ = pulses[n].sweeper.register
else:
RQ = pulses[n].sweeper.aux_register
Expand Down
4 changes: 3 additions & 1 deletion src/qibolab/instruments/qblox/cluster_qcm_rf.py
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,9 @@ def process_pulse_sequence(
and pulses[n].sweeper.type == QbloxSweeperType.duration
):
RI = pulses[n].sweeper.register
if pulses[n].type == PulseType.FLUX:
# FIXME:
# if pulses[n].type == PulseType.FLUX:
if True:
RQ = pulses[n].sweeper.register
else:
RQ = pulses[n].sweeper.aux_register
Expand Down
12 changes: 9 additions & 3 deletions src/qibolab/instruments/qblox/cluster_qrm_rf.py
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,9 @@ def process_pulse_sequence(
comment=f"set relative phase {pulses[n].relative_phase} rads",
)

if pulses[n].type == PulseType.READOUT:
# FIXME:
# if pulses[n].type == PulseType.READOUT:
if True:
delay_after_play = self._ports["i1"].acquisition_hold_off

if len(pulses) > n + 1:
Expand Down Expand Up @@ -742,7 +744,9 @@ def process_pulse_sequence(
and pulses[n].sweeper.type == QbloxSweeperType.duration
):
RI = pulses[n].sweeper.register
if pulses[n].type == PulseType.FLUX:
# FIXME:
# if pulses[n].type == PulseType.FLUX:
if True:
RQ = pulses[n].sweeper.register
else:
RQ = pulses[n].sweeper.aux_register
Expand Down Expand Up @@ -789,7 +793,9 @@ def process_pulse_sequence(
and pulses[n].sweeper.type == QbloxSweeperType.duration
):
RI = pulses[n].sweeper.register
if pulses[n].type == PulseType.FLUX:
# FIXME:
# if pulses[n].type == PulseType.FLUX:
if True:
RQ = pulses[n].sweeper.register
else:
RQ = pulses[n].sweeper.aux_register
Expand Down
9 changes: 6 additions & 3 deletions src/qibolab/instruments/qblox/controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,9 @@ def _sweep_recursion(
elif sweeper.parameter is Parameter.lo_frequency:
initial = {}
for pulse in sweeper.pulses:
if pulse.type == PulseType.READOUT:
# FIXME:
# if pulse.type == PulseType.READOUT:
if True:
initial[pulse.id] = qubits[pulse.qubit].readout.lo_frequency
if sweeper.type == SweeperType.ABSOLUTE:
qubits[pulse.qubit].readout.lo_frequency = value
Expand All @@ -371,8 +373,9 @@ def _sweep_recursion(
qubits[pulse.qubit].readout.lo_frequency = (
initial[pulse.id] * value
)

elif pulse.type == PulseType.DRIVE:
# FIXME:
# elif pulse.type == PulseType.DRIVE:
elif True:
initial[pulse.id] = qubits[pulse.qubit].drive.lo_frequency
if sweeper.type == SweeperType.ABSOLUTE:
qubits[pulse.qubit].drive.lo_frequency = value
Expand Down
4 changes: 3 additions & 1 deletion src/qibolab/instruments/qblox/sequencer.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,9 @@ def bake_pulse_waveforms(
# there may be other waveforms stored already, set first index as the next available
first_idx = len(self.unique_waveforms)

if pulse.type == PulseType.FLUX:
# FIXME:
# if pulses.type == PulseType.FLUX:
if True:
# for flux pulses, store i waveforms
idx_range = np.arange(first_idx, first_idx + len(values), 1)

Expand Down

0 comments on commit 323c6e3

Please sign in to comment.