Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added RX90 native gate and modified R method #1103

Merged
merged 3 commits into from
Nov 28, 2024
Merged

added RX90 native gate and modified R method #1103

merged 3 commits into from
Nov 28, 2024

Conversation

ElStabilini
Copy link
Contributor

I added RX90 as native gate to be able to calibrate this gate separately from the RX gate

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.91%. Comparing base (eca774d) to head (88d0fd1).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/qibolab/_core/native.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
+ Coverage   50.87%   50.91%   +0.03%     
==========================================
  Files          63       63              
  Lines        2905     2909       +4     
==========================================
+ Hits         1478     1481       +3     
- Misses       1427     1428       +1     
Flag Coverage Δ
unittests 50.91% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ElStabilini and others added 2 commits November 26, 2024 05:32
Co-authored-by: Alessandro Candido <[email protected]>
Co-authored-by: Stavros Efthymiou <[email protected]>
@stavros11 stavros11 merged commit 1c2bdf4 into main Nov 28, 2024
28 checks passed
@stavros11 stavros11 deleted the pi_half branch November 28, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants