Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selfhosted tests #641

Merged
merged 36 commits into from
Nov 14, 2023
Merged

Selfhosted tests #641

merged 36 commits into from
Nov 14, 2023

Conversation

GabrielePalazzo
Copy link
Contributor

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

.github/workflows/selfhosted.yml Outdated Show resolved Hide resolved
.github/workflows/selfhosted.yml Outdated Show resolved Hide resolved
.github/workflows/selfhosted.yml Outdated Show resolved Hide resolved
.github/workflows/selfhosted.yml Outdated Show resolved Hide resolved
.github/workflows/selfhosted.yml Outdated Show resolved Hide resolved
.github/workflows/selfhosted.yml Outdated Show resolved Hide resolved
.github/workflows/selfhosted.yml Outdated Show resolved Hide resolved
queues.json Outdated Show resolved Hide resolved
@scarrazza scarrazza added this to the Qibolab 0.1.4 milestone Nov 7, 2023
@stavros11 stavros11 linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link

Run on QPU dummy completed! :atom:

You can download the coverage report as an artifact, from the workflow summary page:
https://github.com/qiboteam/qibolab/actions/runs/6850872838

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GabrielePalazzo. I updated the workflow to also upload the coverage as an artifact, similar to what we were doing before. It seems to work on dummy, so I would suggest to merge this now and check each instrument's tests later as we are refactoring the drivers.

Note that if you want to run on dummy_couplers, you need to modify the queues.json in qibolab_platforms_qrc and assign a queue to dummy_couplers. This is not really required as the only reason to run these tests on dummy is to check if the workflow itself works (for which the dummy is sufficient).

Copy link

Run on QPU dummy completed! :atom:

You can download the coverage report as an artifact, from the workflow summary page:
https://github.com/qiboteam/qibolab/actions/runs/6850968252

@andrea-pasquale andrea-pasquale merged commit 1399148 into main Nov 14, 2023
20 checks passed
@GabrielePalazzo GabrielePalazzo deleted the selfhosted_tests branch November 20, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore QPU tests with label
4 participants