Improved code for selection of measurement start #656
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
==========================================
+ Coverage 65.57% 65.65% +0.07%
==========================================
Files 57 57
Lines 7945 7936 -9
==========================================
Hits 5210 5210
+ Misses 2735 2726 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/qibolab/instruments/zhinst.py
Outdated
| # TODO: if the measure sequence starts after the last pulse, add a delay | ||
| # if the delay is too large (i.e. 5us), |
There was a problem hiding this comment.
Could you check the maximun before it crashes ?
Co-authored-by: Juan Cereijo <[email protected]>
|
If you removed the maximun delay comment can you document what we talked ? |
src/qibolab/instruments/zhinst.py
Outdated
| # self.experiment.save("saved_exp") # saving experiment | ||
| self.exp = self.session.compile(self.experiment, compiler_settings=COMPILER_SETTINGS) | ||
| # self.exp.save("saved_exp") # saving compiled experiment | ||
| self.results = self.session.run(self.exp) |
There was a problem hiding this comment.
Before merging, please drop dead code.
There was a problem hiding this comment.
I asked him to get those lines there to document how to save the experiments in the case Zurich supports asks for them. I would like to have them somewhere.
There was a problem hiding this comment.
Then I would suggest the docstring :)
Fixed the start of the measurement pulse and improved code readability.
Checklist: