-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qblox setting #676
Qblox setting #676
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 65.94% 65.89% -0.06%
==========================================
Files 57 57
Lines 7817 7816 -1
==========================================
- Hits 5155 5150 -5
- Misses 2662 2666 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sorry for all the troubles @stavros11 @alecandido, now all the tests are finally passing and is ready to be merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the QPU tests and there are still two failures but I believe these exist in main so I would not block this PR for it (we can fix them later). I also tried several qibocal routines and they seem to work as expected.
I think we can merge this, thanks @PiergiorgioButtarini.
This fixes qblox tests on qpu.
Here is the report of the qubit spectroscopy (that involves all the three qblox modules) performed with this branch:
http://login.qrccluster.com:9000/tAITAr7YSu-Zz3f6pRfdnQ==
Checklist: