Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qblox setting #676

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Qblox setting #676

merged 10 commits into from
Dec 1, 2023

Conversation

PiergiorgioButtarini
Copy link
Contributor

@PiergiorgioButtarini PiergiorgioButtarini commented Nov 30, 2023

This fixes qblox tests on qpu.
Here is the report of the qubit spectroscopy (that involves all the three qblox modules) performed with this branch:
http://login.qrccluster.com:9000/tAITAr7YSu-Zz3f6pRfdnQ==

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@stavros11 stavros11 added this to the Qibolab 0.1.4 milestone Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (5b1ae2a) 65.94% compared to head (12b4db3) 65.89%.
Report is 102 commits behind head on main.

Files Patch % Lines
src/qibolab/instruments/qblox/controller.py 4.54% 21 Missing ⚠️
src/qibolab/instruments/qblox/cluster_qcm_bb.py 27.27% 8 Missing ⚠️
src/qibolab/instruments/qblox/cluster_qrm_rf.py 20.00% 4 Missing ⚠️
src/qibolab/instruments/qblox/cluster_qcm_rf.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
- Coverage   65.94%   65.89%   -0.06%     
==========================================
  Files          57       57              
  Lines        7817     7816       -1     
==========================================
- Hits         5155     5150       -5     
- Misses       2662     2666       +4     
Flag Coverage Δ
unittests 65.89% <23.40%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiergiorgioButtarini
Copy link
Contributor Author

Sorry for all the troubles @stavros11 @alecandido, now all the tests are finally passing and is ready to be merged!

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the QPU tests and there are still two failures but I believe these exist in main so I would not block this PR for it (we can fix them later). I also tried several qibocal routines and they seem to work as expected.

I think we can merge this, thanks @PiergiorgioButtarini.

@stavros11 stavros11 merged commit 2cdd14f into main Dec 1, 2023
@stavros11 stavros11 deleted the qblox_setting branch December 1, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants