Drop pulse._if dependence in Qblox
#729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiergiorgioButtarini
changed the title
pulse._if dependence in Qblox (never used)pulse._if dependence in Qblox
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
==========================================
+ Coverage 62.88% 62.91% +0.03%
==========================================
Files 48 48
Lines 6603 6599 -4
==========================================
Hits 4152 4152
+ Misses 2451 2447 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alecandido
approved these changes
Dec 27, 2023
andrea-pasquale
approved these changes
Dec 27, 2023
alecandido
added a commit
that referenced
this pull request
Jan 18, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
Merged
alecandido
added a commit
that referenced
this pull request
Jan 20, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
alecandido
added a commit
that referenced
this pull request
Jan 23, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
alecandido
added a commit
that referenced
this pull request
Jan 24, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
alecandido
added a commit
that referenced
this pull request
Jan 29, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
alecandido
added a commit
that referenced
this pull request
Jan 29, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
alecandido
added a commit
that referenced
this pull request
Jan 30, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
stavros11
pushed a commit
that referenced
this pull request
Mar 20, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
stavros11
pushed a commit
that referenced
this pull request
Mar 20, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
stavros11
pushed a commit
that referenced
this pull request
Mar 20, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
hay-k
pushed a commit
that referenced
this pull request
Mar 29, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
hay-k
pushed a commit
that referenced
this pull request
Mar 29, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
stavros11
pushed a commit
that referenced
this pull request
Apr 15, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
alecandido
added a commit
that referenced
this pull request
Apr 15, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
hay-k
pushed a commit
that referenced
this pull request
Apr 16, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
alecandido
added a commit
that referenced
this pull request
Jun 25, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
stavros11
pushed a commit
that referenced
this pull request
Jul 13, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
alecandido
added a commit
that referenced
this pull request
Aug 5, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
alecandido
added a commit
that referenced
this pull request
Aug 16, 2024
Following @PiergiorgioButtarini removal of last usage in Qblox, in #729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulse._ifwas assigned in_execute_pulse_sequenceof the controller but never actually used anywhere, so I just dropped it.Checklist: