Drop pulse tutorial #787
Merged
Drop pulse tutorial #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since pulses are greatly changed, it is much better to rewrite it from scratch, possibly using ideas from the old one, but much of the implementation is going to be reworked anyhow
stavros11
approved these changes
Jan 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #787 +/- ##
=======================================
Coverage 63.14% 63.14%
=======================================
Files 53 53
Lines 5581 5581
=======================================
Hits 3524 3524
Misses 2057 2057
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrea-pasquale
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pulses are greatly changed (and they will keep changing in the next future), it is much better to rewrite it from scratch, possibly using ideas from the old one, but much of the implementation is going to be reworked anyhow