-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule for GPI gate #804
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 63.89% 63.94% +0.04%
==========================================
Files 49 49
Lines 5792 5799 +7
==========================================
+ Hits 3701 3708 +7
Misses 2091 2091
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrea-pasquale. The implementation looks correct to me, but it would be if @igres26 or @renatomello who have more experience with IONQ can also confirm.
We should keep in mind that the matrix representation of this gate has det=-1, unlike U3, GPI2 and others that have det=1, so we may have similar issues to the ones we had with the Hadamard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a global phase difference of what we are doing and the explicit matrix. We might want to note that.
Thanks for the review @igres26 @stavros11. |
Closes #551.
Adding rule for implementing GPI gate as R(pi) gate with arbitrary azimuthal angle.
I believe that I don't need to do anything in Qibo, right?
Checklist: