Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of crosstalk_matrix #813

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Feb 22, 2024

This PR fixes the crosstalk_matrix deserialization which was broken after switching from yaml to json.
I found this bug while testing qiboteam/qibocal#684.
If someone knows a more elegant solution let me know.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Feb 22, 2024
@andrea-pasquale andrea-pasquale added this to the Qibolab 0.1.6 milestone Feb 22, 2024
@andrea-pasquale andrea-pasquale self-assigned this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c8650b) 65.10% compared to head (e717b9f) 65.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
+ Coverage   65.10%   65.13%   +0.02%     
==========================================
  Files          50       50              
  Lines        6027     6031       +4     
==========================================
+ Hits         3924     3928       +4     
  Misses       2103     2103              
Flag Coverage Δ
unittests 65.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido
Copy link
Member

If someone knows a more elegant solution let me know.

I know: stop using non-integer IDs for serialization and move the matrix out of the single qubit :P

@andrea-pasquale andrea-pasquale merged commit 5953517 into main Feb 26, 2024
26 checks passed
@stavros11 stavros11 deleted the deserialize_crosstalk_matrix branch February 28, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants