Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the hotfix: Single unsplit section #858

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Fix the hotfix: Single unsplit section #858

merged 2 commits into from
Mar 29, 2024

Conversation

hay-k
Copy link
Contributor

@hay-k hay-k commented Mar 28, 2024

#848 introduced the section for unsplit channels, but it would face issues if a single experiment applies long flux pulses on multiple places (e.g. on qubit and coupler flux channels). The issue being the non-uniqueness of the section name. All unsplit channels should just constitute a single section. Additionally, the pulse start time is accounted for as well, although there is no known use case for it.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link
Contributor

@Jacfomg Jacfomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@hay-k hay-k force-pushed the single-unsplit-section branch from 0a09e3e to fa9d144 Compare March 29, 2024 06:20
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.66%. Comparing base (48d0352) to head (fa9d144).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files          55       55           
  Lines        5900     5901    +1     
=======================================
+ Hits         3933     3934    +1     
  Misses       1967     1967           
Flag Coverage Δ
unittests 66.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido
Copy link
Member

@hay-k would you add a test, failing for main and passing for this branch?

This would prevent a possible regression.

@hay-k hay-k merged commit abe3698 into main Mar 29, 2024
24 checks passed
@stavros11 stavros11 deleted the single-unsplit-section branch March 29, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants