Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating README badges #105

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Updating README badges #105

merged 3 commits into from
Feb 8, 2024

Conversation

andrea-pasquale
Copy link
Contributor

Hi @rodolfocarobene,

following qiboteam/qibolab#788 we have decided to change a bit the README (mostly using different badges) for all our qibo repositories.
Let me know if you like it.

Checklist before merge:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Documentation is updated.

@andrea-pasquale andrea-pasquale added the documentation Improvements or additions to documentation label Feb 8, 2024
@andrea-pasquale andrea-pasquale self-assigned this Feb 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3334055) 94.16% compared to head (5ad915d) 94.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files          12       12           
  Lines         703      703           
=======================================
  Hits          662      662           
  Misses         41       41           
Flag Coverage Δ
unittests 94.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodolfocarobene
Copy link
Contributor

Thanks @andrea-pasquale! It is also your first qibosoq contribution I believe :-)

To me, looks fine. However, I think I would leave also the link to the latest documentation.

@andrea-pasquale
Copy link
Contributor Author

Thanks @andrea-pasquale! It is also your first qibosoq contribution I believe :-)

You are correct :)

To me, looks fine. However, I think I would leave also the link to the latest documentation.

Sure I can add it back.

README.md Outdated Show resolved Hide resolved
@rodolfocarobene rodolfocarobene merged commit 92fa386 into main Feb 8, 2024
25 checks passed
@rodolfocarobene rodolfocarobene deleted the badges branch February 8, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants