Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualization tools for single-qubit POVMs and products of single-qubit POVMs. #17

Merged
merged 18 commits into from
May 21, 2024
Merged

Visualization tools for single-qubit POVMs and products of single-qubit POVMs. #17

merged 18 commits into from
May 21, 2024

Conversation

timmintam
Copy link
Collaborator

Draw the Bloch sphere representation of rank-1 single-qubit POVMs (and product of those).

Tackles parts of #3

@timmintam timmintam marked this pull request as ready for review May 17, 2024 08:55
@timmintam timmintam requested a review from mrossinek as a code owner May 17, 2024 08:55
mrossinek
mrossinek reviewed May 21, 2024
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, thanks! 👍

docs/how_tos/visualization.ipynb Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/multi_qubit_povm.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/product_povm.py Show resolved Hide resolved
povm_toolbox/quantum_info/product_povm.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/single_qubit_povm.py Show resolved Hide resolved
povm_toolbox/quantum_info/single_qubit_povm.py Outdated Show resolved Hide resolved
mrossinek
mrossinek approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit picks, other than that this is good to go 👍

docs/how_tos/visualization.ipynb Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/multi_qubit_povm.py Outdated Show resolved Hide resolved
@mrossinek mrossinek enabled auto-merge (squash) May 21, 2024 13:23
@mrossinek mrossinek merged commit 058cdff into main May 21, 2024
8 checks passed
@mrossinek mrossinek deleted the visualize_single_qubit_povm branch July 17, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrossinek mrossinek mrossinek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmintam @mrossinek