-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Adding apply
to SummedPauliOp
#80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck that the parallel versions are faster than the serial
…uliOp.apply_weighted
jamesETsmith
added
bug
Something isn't working
enhancement
New feature or request
labels
Oct 29, 2024
Signed-off-by: jamesETsmith <[email protected]>
…ests of SummedPauliOps
…final contraction. This is also how we'd do it if we were going to reuse that map from P^n --> P^2n
…std::reduce was 'ill-formed' and GCC builds would crash
stand-by
requested changes
Nov 5, 2024
…her small changes
stand-by
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you James
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
This PR add$\sum_k \sum_j h_{jk} \mathcal{P}_j \ket{\psi_t}$ and has some small performance tweaks for
SummedPauilOp.apply
for the operation:SummedPauliOp.apply_weighted
.Details
SummedPauilOp.apply
apply_weighted
andexpectation_value
where theExecutionPolicy
wasn't being checked properly and it was always running seriallyUpdate on
SummedPauliOp.square
I've implemented the
square
function to create aSummedPauliOp
from sparse utilities that's equivalent to (A_k)^2. We do not save the "map"t_aij
like we'd want to if we call this function immediately, but introducing that capability in the future should be straightforward if we want to.In terms of performance,
Remaining TODOs
to_tensor
SummedPauliOp
squared to a set of statesSummedPauliOp
methods