Added package names for functions

qossmic · Jul 12, 2023 · 80800bc · 80800bc
1 parent 2388165
commit 80800bc
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 0 deletions.
diff --git a/src/Core/Ast/Parser/NikicPhpParser/FileReferenceVisitor.php b/src/Core/Ast/Parser/NikicPhpParser/FileReferenceVisitor.php
@@ -189,6 +189,19 @@ private function enterFunction(Node\Stmt\Function_ $node): void
                 }
             }
         }
+
+        $docComment = $node->getDocComment();
+        if (null !== $docComment) {
+            $tokens = new TokenIterator($this->lexer->tokenize($docComment->getText()));
+            $docNode = $this->docParser->parse($tokens);
+            $packageNames = array_map(
+                static fn (PhpDocTagNode $docNode) => new PackageName((string) $docNode->value),
+                $docNode->getTagsByName('@package')
+            );
+            foreach ($packageNames as $packageName) {
+                $this->currentReference->addMetaDatum($packageName);
+            }
+        }
     }
 
     private function getClassReferenceName(ClassLike $node): ?string

diff --git a/tests/Core/Ast/Parser/NikicPhpParser/Fixtures/PackageNames.php b/tests/Core/Ast/Parser/NikicPhpParser/Fixtures/PackageNames.php
@@ -12,3 +12,14 @@ class PackageAClass
 class NoPackageClass
 {
 }
+
+/**
+ * @package PackageB
+ */
+function packageBFunction(): void
+{
+}
+
+function noPackageFunction(): void
+{
+}
diff --git a/tests/Core/Ast/Parser/NikicPhpParser/NikicPhpParserTest.php b/tests/Core/Ast/Parser/NikicPhpParser/NikicPhpParserTest.php
@@ -113,5 +113,15 @@ public function testParsePackageNames(): void
 
         $packageNames = array_filter($astClassReferences[1]->getMetaData(), $filterPackageNames);
         self::assertCount(0, $packageNames);
+
+        $astFunctionReferences = $astFileReference->functionReferences;
+        self::assertCount(2, $astFunctionReferences);
+
+        $packageNames = array_filter($astFunctionReferences[0]->getMetaData(), $filterPackageNames);
+        self::assertCount(1, $packageNames);
+        $this->assertSame('PackageB', $packageNames[0]->getPackageName());
+
+        $packageNames = array_filter($astFunctionReferences[1]->getMetaData(), $filterPackageNames);
+        self::assertCount(0, $packageNames);
     }
 }