Update the qtap-operator type to support the new functionality for labelling and injection #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…belling and injection.
marc-barry
commented
Dec 2, 2023
| annotationsYaml: |- | ||
| qpoint.io/inject-ca: "true" | ||
| qpoint.io/egress-init-tag: "v0.0.7" | ||
| qpoint.io/egress-to-domain: "qtap-gateway.qpoint.svc.cluster.local" | ||
| qpoint.io/egress-port-mapping: "10080:80,10443:443" | ||
| qpoint.io/qtap-tag: "v0.0.10" |
There was a problem hiding this comment.
This will use https://github.com/qpoint-io/qtap/releases/tag/v0.0.10.
marc-barry
commented
Dec 2, 2023
| qpoint.io/egress-to-domain: "qtap-gateway.qpoint.svc.cluster.local" | ||
| qpoint.io/egress-port-mapping: "10080:80,10443:443" | ||
| qpoint.io/qtap-tag: "v0.0.10" | ||
| qpoint.io/egress-port-mapping: "10080:80,10443:443,10000:" |
There was a problem hiding this comment.
This will egress route all TCP ports.
tylerflint
approved these changes
Dec 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With https://github.com/qpoint-io/kubernetes-qtap-operator/releases/tag/v0.0.5 sidecar injection is now support, CA fetching and simplified labelling are now supported. The new labelling scheme can be found in qpoint-io/kubernetes-qtap-operator#16.