This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Address CA config map creation race condition #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During rapid mutation of pods with the
qpoint.io/inject-ca: "true"
annotation it is possible that a race condition occurs that leads to the following error:The issue is that the config map already exists due a a race condition with multiple calls to
EnsureAssetsInNamespace()
and multiple attempts to create the same config map. This pull request locks the write part of the function call so only one can be in-flight at any given time to prevent creation errors.