[4135][ADD] account_invoice_line_salesperson #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yostashiro
requested changes
Jul 17, 2024
Comment on lines
14
to
21
| @api.depends("sale_line_ids.order_id.user_id", "invoice_id.user_id") | ||
| def _compute_salesperson(self): | ||
| for line in self: | ||
| line.user_id = line.invoice_id.user_id | ||
| if line.sale_line_ids: | ||
| line.user_id = line.sale_line_ids[0].order_id.user_id |
There was a problem hiding this comment.
Suggested change
| @api.depends("sale_line_ids.order_id.user_id", "invoice_id.user_id") | |
| def _compute_salesperson(self): | |
| for line in self: | |
| line.user_id = line.invoice_id.user_id | |
| if line.sale_line_ids: | |
| line.user_id = line.sale_line_ids[0].order_id.user_id | |
| @api.multi | |
| @api.depends("sale_line_ids.order_id.user_id", "invoice_id.user_id") | |
| def _compute_salesperson(self): | |
| for line in self: | |
| if line.invoice_type not in ("out_invoice", "out_refund"): | |
| continue | |
| if line.sale_line_ids: | |
| line.user_id = line.sale_line_ids[0].order_id.user_id | |
| continue | |
| line.user_id = line.invoice_id.user_id |
AungKoKoLin1997
force-pushed
the
4135-account_invoice_line_salesperson
branch
from
18be208 to
fb63be9
Compare
yostashiro
reviewed
Jul 17, 2024
Comment on lines
9
to
10
| <field name="invoice_type" invisible="1" /> | ||
| <field name="user_id" attrs="{'invisible': [('invoice_type', 'not in', ['out_invoice', 'out_refund'])]}"/> |
There was a problem hiding this comment.
I think it's redundant to consider invoice_type here. account.invoice_form is only used for out_invoice and out_refund, IIUC.
There was a problem hiding this comment.
My mistake. I thought they shared the same view like another versions.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
kanda999
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4135