Fix pr test job submission #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwasilew
requested review from
quic-vkraleti,
ricardosalveti,
sbanerjee-quic and
ndechesne
as code owners
lumag
reviewed
Jan 21, 2025
| if (!fs.existsSync(temp)){ | ||
| fs.mkdirSync(temp); | ||
| } | ||
| fs.writeFileSync(path.join(temp, 'build_url.zip'), Buffer.from(download.data)); |
There was a problem hiding this comment.
I think it comes from the upload-action which zips the content by default: https://github.com/actions/upload-artifact?tab=readme-ov-file#inputs. This code comes from github example
This change allows to keep the base URL in one place and helps avoid mistakes when changing it. Signed-off-by: Milosz Wasilewski <[email protected]>
This is required for running tests after PR builds. Tests triggered after PR build will use the artifact file to retrieve base download URL. Signed-off-by: Milosz Wasilewski <[email protected]>
Workflows triggered by "workflow_run" event don't receive any variables from triggering event. the only way to pass the variable is throught the uploaded artifact test-pr workflow is triggered by PR build completion. This patch allows test-pr to retrieve the build_url from saved artifact before triggering tests. Signed-off-by: Milosz Wasilewski <[email protected]>
Display title is set to title of the PR that triggered original build Signed-off-by: Milosz Wasilewski <[email protected]>
mwasilew
force-pushed
the
fix-pr-test-job-submission
branch
from
104d173 to
6f77043
Compare
|
I rebased on top of current main and addressed the comments. |
ricardosalveti
approved these changes
Jan 22, 2025
ndechesne
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.