Add CODEOWNERS #44
Merged
Add CODEOWNERS #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sbanerjee-quic <[email protected]>
This was referenced Oct 15, 2024
.github/CODEOWNERS
Outdated
| recipes-kernel/linux/* @NainaMehtaQUIC @quic-vkraleti @sbanerjee-quic | ||
|
|
||
| # Reviewers responsible for all changes in entire repository | ||
| * @quic-vkraleti @ricardosalveti @sbanerjee-quic |
There was a problem hiding this comment.
I think the last matching pattern takes the most precedence so this will probably just assign everything to all 3 here.
There was a problem hiding this comment.
addressed by moving the catchall line to the top.
Signed-off-by: sbanerjee-quic <[email protected]>
mynameistechno
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reviewers are assigned based on the files changed.
I am thinking the last line, i.e., rule with *, will help one of maintainers to be added as reviewers apart from the match that happens in previous lines. Thus, if there is a change in recipes-kernel/linux/ then reviewers will be assigned from both groups.
Need to test this though.