Add SBOM filter to allow image distribution #60
Closed
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwamartur
requested review from
quaresmajose,
ricardosalveti,
sbanerjee-quic and
quic-vkraleti
as code owners
vishwamartur
force-pushed
the
add-sbom-filter
branch
from
d060292 to
c413340
Compare
Related to #40 Add post build filter to clear out generated SBOM files. * Modify `ci/yocto-check-layer.sh` to include a step that uses the `find` command to locate and delete SBOM files. * Update `ci/base.yml` to add a post build filter section that uses the `find` command to locate and delete SBOM files. * Modify `.github/workflows/build-yocto.yml` to include a step that uses the `find` command to locate and delete SBOM files after the publish image step. Signed-off-by: Vishwanath Martur <[email protected]>
vishwamartur
force-pushed
the
add-sbom-filter
branch
from
c413340 to
39eb3c4
Compare
|
I am most likely missing the context about this change. But I do not understand why your patch is needed. |
|
I updated qualcomm-linux/meta-qcom#716 to better describe what we need here, which is actually validating the generated sbom (based on the image artifacts) against a list of pre-approved packages (sbom filtering), to allow image distribution. This change is just erasing the sbom, which is not really wanted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to qualcomm-linux/meta-qcom#716
Add post build filter to clear out generated SBOM files.
ci/yocto-check-layer.shto include a step that uses thefindcommand to locate and delete SBOM files.ci/base.ymlto add a post build filter section that uses thefindcommand to locate and delete SBOM files..github/workflows/build-yocto.ymlto include a step that uses thefindcommand to locate and delete SBOM files after the publish image step.