-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rb3gen2 partition conf and boot firmware with the qclinux 1.3 release #731
Conversation
Creating as WIP due issue #714, since here I'm just updating the partition conf, and not including the final xml and not using the new qcom-ptool repo yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could merge this change. I know we want to move things to qcom-ptool, but in the mean time there is nothing wrong with keeping meta-qcom up-to-date.
Sure, once we have all the xml files available in the other repo we can migrate here. |
Update partitions based on the same updates that were published as part of the qclinux 1.3 release, aligning partition names, guids and filenames. Signed-off-by: Ricardo Salveti <[email protected]>
Firmware available as part of the Qualcomm Linux 1.3 release. Known changes: - KVM support via xbl_config_kvm.elf - UEFI variable runtime support (read-only since write requires RPMB) - UEFI Capsule Update via capsule as file Signed-off-by: Ricardo Salveti <[email protected]>
de874d8
to
27fd6c6
Compare
@mwasilew with this merged we should be able to test efi runtime support (not yet stable, fails sometimes, but available), capsule updates and kvm support. Should we just create issues against meta-qcom or do we want to track what we want to test somewhere else? |
--partition --lun=2 --name=xbl_a --size=3604KB --type-guid=DEA0BA2C-CBDD-4805-B4F9-F428251C3E98 --filename=xbl.elf | ||
--partition --lun=2 --name=xbl_config_a --size=512KB --type-guid=5A325AE4-4276-B66D-0ADD-3494DF27706A --filename=xbl_config.elf | ||
--partition --lun=2 --name=xbl_b --size=3604KB --type-guid=7A3DF1A3-A31A-454D-BD78-DF259ED486BE | ||
--partition --lun=2 --name=xbl_config_b --size=512KB --type-guid=F462E0EA-A20E-4B10-867A-2D4455366548 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Why do we have now two versions of xbl_*
partitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PBL supports loading xbl_b (via guid) on the same active boot LUN, but cannot switch the boot LUN, that is why they added a backup / secondary boot LUN replicating the same xbl a and b. Same was done for lemans and monaco.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this is what caused linux-msm/qdl#87 as well. Main use case was to have a boot lun recovery mechanism from what I know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which of those will be selected by Linux for the xbl_a
name in /dev/disk/by-partlabel
? I think this might confuse users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is confusing, same label and GUID (as needed by PBL). When checking at runtime it is linking from lun 1, probably because it gets parsed first.
Setting bootable to lun 2 would probably confuse things for users.
issues in meta-qcom are OK with me. |
PR to bring the latest partition conf and boot firmware from qclinux 1.3.
Relevant boot firmware changes:
As with qclinux 1.3, it requires UFS reprovisioning as described at https://docs.qualcomm.com/bundle/publicresource/topics/80-70017-253/set_up_the_device.html?vproduct=1601111740013072&version=1.3#ubuntu-machine