Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of operations in Tableau.__call__.__doc__ #786

Closed
wants to merge 4 commits into from

Conversation

amirebrahimi
Copy link
Contributor

This is minor, but I figure it might save someone else some time.

Copy link

google-cla bot commented Jun 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@amirebrahimi
Copy link
Contributor Author

I just signed the CLA, so not sure if it will require CI to rerun.

@Strilanc
Copy link
Collaborator

Everyone always edits the generated docs instead of the source.

If the multiplication is in circuit order, then that's the wrong way around. I should fix that and then also separately describe it as "before/after" so it's clearer.

@amirebrahimi
Copy link
Contributor Author

amirebrahimi commented Jun 21, 2024

This seems to be consistent with what is specified here, though.

@Strilanc Strilanc enabled auto-merge (squash) September 10, 2024 03:45
@Strilanc Strilanc changed the title Clarify docs Fix order of operations in Tableau.__call__.__doc__ Sep 10, 2024
@Strilanc Strilanc disabled auto-merge September 10, 2024 03:46
@Strilanc Strilanc enabled auto-merge (squash) September 10, 2024 03:46
@Strilanc
Copy link
Collaborator

Fixes #819

@Strilanc
Copy link
Collaborator

Moved to #822 so I could edit it to get it merged. Thanks for the fix!

@Strilanc Strilanc closed this Sep 10, 2024
auto-merge was automatically disabled September 10, 2024 03:54

Pull request was closed

Strilanc added a commit that referenced this pull request Sep 13, 2024
Derived from #786, after
regenerating docs

Fixes #819

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Amir Ebrahimi <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt McEwen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants