Add Azure Key Vault tests and test open-telemetry extension compatibility #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jianguo Ma <[email protected]>
Signed-off-by: Jianguo Ma <[email protected]>
…egration test results Signed-off-by: Jianguo Ma <[email protected]>
Signed-off-by: Jianguo Ma <[email protected]>
majguo
changed the title
majguo
requested review from
backwind1233 and
galiacheng
and removed request for
a team
galiacheng
approved these changes
Jan 21, 2025
Signed-off-by: Jianguo Ma <[email protected]>
majguo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #335, this pull request includes multiple changes to various integration test modules and documentation, primarily focusing on adding new test cases for Azure Key Vault secrets to test compatibility with open-telemetry extension, improving test commands and fixing typos. Here are the most important changes:
New Test Classes:
azure-services-togethermodule (integration-tests/azure-services-together/src/test/java/io/quarkiverse/azure/services/together/it/KeyVaultSecretResourceIT.java,integration-tests/azure-services-together/src/test/java/io/quarkiverse/azure/services/together/it/KeyVaultSecretResourceTest.java). [1] [2]azure-services-togethermodule (integration-tests/azure-services-together/README.md,integration-tests/azure-services-together/src/main/java/io/quarkiverse/azure/services/together/it/KeyVaultSecretResource.java). [1] [2] [3]Dependency Updates:
azure-services-togethermodule (integration-tests/azure-services-together/pom.xml).Documentation Updates:
failsafe:verifyin multipleREADME.mdfiles to ensure proper test execution (integration-tests/azure-app-configuration/README.md,integration-tests/azure-cosmos/README.md,integration-tests/azure-eventhubs/README.md,integration-tests/azure-keyvault/README.md,integration-tests/azure-services-together/README.md,integration-tests/azure-storage-blob/README.md). [1] [2] [3] [4] [5] [6]Code Fixes:
KeyVaultSecretResourceclass and its corresponding test class (integration-tests/azure-keyvault/src/main/java/io/quarkiverse/azure/keyvault/secret/it/KeyVaultSecretResource.java,integration-tests/azure-keyvault/src/test/java/io/quarkiverse/azure/keyvault/secret/it/KeyVaultSecretResourceTest.java). [1] [2]Test passed: https://github.com/majguo/quarkus-azure-services/actions/runs/12878123422
Signed-off-by: Jianguo Ma [email protected]