Merge pull request #756 from jfbenckhuijsen/feature/use-fabri8-for-np…

…m-install Initial version, try run npm install from docker-maven-plugin
quarkiverse · Jan 28, 2025 · ad6976a · ad6976a
2 parents 36d88f3 + 2b64440
commit ad6976a
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -30,10 +30,6 @@ jobs:
         cache: 'npm'
         cache-dependency-path: firebase-devservices/deployment/src/test/functions/package-lock.json
 
-    - uses: bahmutov/npm-install@v1
-      with:
-        working-directory: firebase-devservices/deployment/src/test/functions
-
     - name: Cache local Maven repository
       uses: actions/cache@v2
       with:

diff --git a/.github/workflows/quarkus-snapshot.yaml b/.github/workflows/quarkus-snapshot.yaml
@@ -42,10 +42,6 @@ jobs:
           repository: ${{ env.ECOSYSTEM_CI_REPO }}
           path: ecosystem-ci
 
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 20
-
       - uses: bahmutov/npm-install@v1
         with:
           working-directory: current-repo/firebase-devservices/deployment/src/test/functions

diff --git a/firebase-devservices/deployment/pom.xml b/firebase-devservices/deployment/pom.xml
@@ -152,6 +152,41 @@ quarkus-google-cloud-common-grpc and Quarkus includes the netty library -->
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <groupId>io.fabric8</groupId>
+                <artifactId>docker-maven-plugin</artifactId>
+                <version>0.45.1</version>
+                <executions>
+                    <execution>
+                        <id>npm-install-before-testing</id>
+                        <goals>
+                            <goal>stop</goal>
+                            <goal>start</goal>
+                        </goals>
+                        <phase>process-test-resources</phase>
+                        <configuration>
+                            <images>
+                                <image>
+                                    <!-- Node version must match version in package.json -->
+                                    <name>node:20</name>
+                                    <run>
+                                        <cmd>npm install</cmd>
+                                        <workingDir>/tmp/node</workingDir>
+                                        <volumes>
+                                            <bind>
+                                                <volume>src/test/functions:/tmp/node</volume>
+                                            </bind>
+                                        </volumes>
+                                        <wait>
+                                            <exit>0</exit>
+                                        </wait>
+                                    </run>
+                                </image>
+                            </images>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
     </build>