add weather sample server #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
reviewed
Jan 10, 2025
|
|
||
| ## just for debugging | ||
| #quarkus.log.level=DEBUG | ||
| #quarkus.mcp.server.traffic-logging.enabled=true |
There was a problem hiding this comment.
Traffic logging currently only works for the sse transport and the property name is quarkus.mcp.server.sse.traffic-logging.enabled.
I forgot to update the docs 🤦
Do you think it would be useful for stdio as well?
There was a problem hiding this comment.
yeah would be nice to have in logs to at least see something is reacting.
There was a problem hiding this comment.
Ok, I'll revert the change and make it quarkus.mcp.server.traffic-logging.enabled again and implement the logging for stdio...
|
i've pushed the last polish for blog. can we merge so i can link? |
mkouba
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding as draft as working on blog that explain the weather mcp implementation and would be nice to have a "home" for it.
would this sample folder work?