Refactor: NuxtFramework

[shivarm]

Check List (Check all the applicable boxes)

• My code follows the code style of this project.
• All new and existing tests passed.

[melloware]

Title looks good, Nice PR.

[ia3andy]

Coould you use the NextFramework class that you copied (instead of duplicating), and just edit the build dir, if it's really a different one.

@melloware did you check it works?

[ia3andy]

@shivam-sharma7
Have a look to this file: https://github.com/quarkiverse/quarkus-quinoa/blob/478fcac129cdc00dc7525a2e381b4c8626f053e7/deployment/src/main/java/io/quarkiverse/quinoa/deployment/framework/override/NuxtFramework.java

Then this file:
https://github.com/quarkiverse/quarkus-quinoa/blob/478fcac129cdc00dc7525a2e381b4c8626f053e7/deployment/src/main/java/io/quarkiverse/quinoa/deployment/framework/override/NextFramework.java

[melloware]

I am not familiar with Nuxt but I assume its different than Next?

[ia3andy]

I am not familiar with Nuxt but I assume its different than Next?

It's a different framework, but the logic for detection seems to be similar

[ia3andy]

At least from the PR code, I am not familiar with it either.

[melloware]

Oh i see what you are saying its so similar to Next should we refactor these two to be similar and just override the script its looking for?

[ia3andy]

Oh i see what you are saying its so similar to Next should we refactor these two to be similar and just override the script its looking for?

yes and the build dir needs to be checked

[ia3andy]

From what you are saying, it looks to me that Nuxt is a regular (generic) framework. @melloware could you have a look?

[melloware]

@shivam-sharma7 I don't understand what with Nuxt is NOT working with the current code?

NUXT(Set.of("nuxt dev"), generic("dist", "dev", 3000)),

[melloware]

@shivam-sharma7 Using the current 2.2.1 plugin Nuxt works out of the box.

Attached zip:
nuxt.zip

Unzip the project and Run mvn quarkus:dev and navigate to https://localhost:8080 its working fine?

[ia3andy]

Something you can do though is print some Warning if no "build" is found on the GenericFramework.