Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade Quarkus version to 3.2.6.Final #45

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

chberger
Copy link
Contributor

No description provided.

@chberger
Copy link
Contributor Author

@wjglerum Would you like to review this PR? This is the last change before you could start with the Wiremock 3 integration.

@chberger
Copy link
Contributor Author

@all-contributors add @chberger for doc

@allcontributors
Copy link
Contributor

@chberger

I've put up a pull request to add @chberger! 🎉

@@ -11,3 +11,6 @@ updates:
interval: "daily"
ignore:
- dependency-name: "org.apache.maven.plugins:maven-compiler-plugin"
# For Quarkus, ignore all minor updates to stay on LTS stream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason for sticking to the LTS stream here? do other extension do the same? 🤔

Will this break compatibility with this extension if I upgrade my app to 3.5.x for example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically it could break, practically I don't think it will, but you never know. :-)

Quarkus develops at a very fast pace. I have the fear that it will be some effort to keep this extension in sync. By just supporting the LTS officially, it makes things easier. Although there is a high chance that this extension will even work with the latest version of Quarkus. In case of a breaking change we can react anyway.

For the moment I would go with the LTS support only. In case the project has some more contributors we could even support the latest and greatest versions officially :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjglerum does it sound fair enough?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, let's start with the LTS first! Im happy to help out btw :)

@chberger chberger merged commit a2c79f6 into main Oct 17, 2023
1 check passed
@chberger chberger deleted the feature/quarkus3 branch October 17, 2023 14:27
@chberger
Copy link
Contributor Author

@all-contributors add @wjglerum for review

@allcontributors
Copy link
Contributor

@chberger

I've put up a pull request to add @wjglerum! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants