-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable global response templating #51
feat: enable global response templating #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank your very much for your contribution. Your work is very appreciated. Unfortunately, the implementation is based on the WireMock 2
approach, but we'd like to traget WireMock 3
. Maybe we can merge the most parts of this PR into X.0
, but I would ask for a rework when targeting main
. Thank you so much.
Edit: Ah my fault, you're targeting 0.x
:-) Then I have just some minor comments.
deployment/src/main/java/io/quarkiverse/wiremock/devservice/WireMockServerConfig.java
Show resolved
Hide resolved
deployment/src/main/java/io/quarkiverse/wiremock/devservice/WireMockServerProcessor.java
Show resolved
Hide resolved
deployment/src/test/java/io/quarkiverse/wiremock/devservice/WireMockTemplatingTest.java
Outdated
Show resolved
Hide resolved
yeah was going to make another one for Quarkus 3 + WireMock 3 :) thanks for the review! |
@chberger addressed your concerns, I'll continue this work for WireMock 3 with a PR to the main branch next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks! 👍
@all-contributors add @wjglerum for doc |
I've put up a pull request to add @wjglerum! 🎉 |
See https://wiremock.org/2.x/docs/response-templating/