Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable global response templating #51

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

wjglerum
Copy link
Contributor

Copy link
Contributor

@chberger chberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your very much for your contribution. Your work is very appreciated. Unfortunately, the implementation is based on the WireMock 2 approach, but we'd like to traget WireMock 3. Maybe we can merge the most parts of this PR into X.0, but I would ask for a rework when targeting main. Thank you so much.

Edit: Ah my fault, you're targeting 0.x :-) Then I have just some minor comments.

@wjglerum
Copy link
Contributor Author

Thank your very much for your contribution. Your work is very appreciated. Unfortunately, the implementation is based on the WireMock 2 approach, but we'd like to traget WireMock 3. Maybe we can merge the most parts of this PR into X.0, but I would ask for a rework when targeting main. Thank you so much.

Edit: Ah my fault, you're targeting 0.x :-) Then I have just some minor comments.

yeah was going to make another one for Quarkus 3 + WireMock 3 :) thanks for the review!

@wjglerum
Copy link
Contributor Author

@chberger addressed your concerns, I'll continue this work for WireMock 3 with a PR to the main branch next.

Copy link
Contributor

@chberger chberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks! 👍

@chberger
Copy link
Contributor

@all-contributors add @wjglerum for doc

@allcontributors
Copy link
Contributor

@chberger

I've put up a pull request to add @wjglerum! 🎉

@chberger chberger merged commit aab743a into quarkiverse:0.x Oct 18, 2023
1 check passed
@wjglerum wjglerum deleted the feature/global-response-templating branch October 19, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants