Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): implement eth mainnet uniswap v3 resolver #2

Merged

Conversation

0xpanoramix
Copy link
Contributor

Description

This PR adds a new controller for the positions resource.

It adds the implementation of the first resolver, for UniswapV3 on Ethereum Mainnet, which fetches one's positions and associated extra-data.

Changes include

  • Bugfix (non-breaking change that solves an issue).
  • Hotfix (change that solves an urgent issue, and requires immediate attention).
  • New feature (non-breaking change that adds functionality).
  • Breaking change (change that is not backwards-compatible and/or changes current functionality).
  • Documentation update (change added to any kind of documentation).

Checklist

  • I have assigned this PR to myself.
  • I have added at least 1 reviewer.
  • I have added the relevant labels.
  • I have updated the official documentation.
  • I have added sufficient documentation in code.

Testing

  • I have tested this code with the official test suite.
  • I have tested this code manually.

Manual tests

I started the backend and attempted to get the positions for multiple addresses on Ethereum Mainnet.

0xpanoramix added 11 commits May 6, 2024 17:53
Signed-off-by: Luca Georges Francois <[email protected]>
Signed-off-by: Luca Georges Francois <[email protected]>
Signed-off-by: Luca Georges Francois <[email protected]>
Signed-off-by: Luca Georges Francois <[email protected]>
Signed-off-by: Luca Georges Francois <[email protected]>
Signed-off-by: Luca Georges Francois <[email protected]>
Signed-off-by: Luca Georges Francois <[email protected]>
Signed-off-by: Luca Georges Francois <[email protected]>
@0xpanoramix 0xpanoramix added the backend Changes or improvements related to the backend service. label May 8, 2024
@0xpanoramix 0xpanoramix self-assigned this May 8, 2024
@0xpanoramix 0xpanoramix merged commit eb8b728 into main May 8, 2024
1 check passed
@0xpanoramix 0xpanoramix deleted the 0xpanoramix/implement-eth-mainnet-uniswap-v3-resolver branch May 8, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes or improvements related to the backend service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant