gui: rename logo's filename to icon name #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The desktop file specifies the name of the icon with its app ID, while the logo file is named "goldwarden.svg". Make the filename & the icon name match.
|
Nice! Thank you for the PR! |
|
Also change the name in readme.md where the reference is to the old name of the icon. The github readme does not show the icon right now. |
quexten
added a commit
that referenced
this pull request
Oct 20, 2024
Readme: update logo filename (hotfix for #293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The desktop file specifies the name of the icon with its app ID, while the logo file is named "goldwarden.svg". Make the filename & the icon name match.
This is mainly to aid non-Flatpak packages. Goldwarden has no installer, & renaming the icon is something packagers might not expect. So just use the filename that is used when the package is installed.
Fixes: #292