Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use https for git submodules to use CA PKI instead of SSH TOFU #1553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nxxxse
Copy link

@nxxxse nxxxse commented Jan 8, 2025

Description

For users just cloning this, ssh is incontinent because of

The authenticity of host 'github.com (140.82.121.4)' can't be established.                                                                                    
ED25519 key fingerprint is SHA256:+DiY3wvvV6TuJJhbpZisF/zLDA0zPMSvHdkr4UvCOqU.                                                                                
This key is not known by any other names.                                                                                                                     
Are you sure you want to continue connecting (yes/no/[fingerprint])? no        
Host key verification failed.                                                                                                                                 
fatal: Could not read from remote repository.

Defaulting to HTTPS avoids this.

  • Closes #
  • Fixes #
  • Resolves #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Packaging (updates the packaging)
  • Documentation (updates the documentation)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections
  • I have made corresponding changes to the documentation (remove if no documentation changes were required)

For users just cloning this, ssh is incontinent because of 

```
The authenticity of host 'github.com (140.82.121.4)' can't be established.                                                                                    
ED25519 key fingerprint is SHA256:+DiY3wvvV6TuJJhbpZisF/zLDA0zPMSvHdkr4UvCOqU.                                                                                
This key is not known by any other names.                                                                                                                     
Are you sure you want to continue connecting (yes/no/[fingerprint])? no        
Host key verification failed.                                                                                                                                 
fatal: Could not read from remote repository.
```

Defaulting to HTTPS avoids this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant