[BUG] replicaCount must accept zero #128
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please your review @guilload. |
katlim-br
changed the title
katlim-br
changed the title
guilload
approved these changes
Feb 3, 2025
|
Thanks for the approval @guilload. Can you please merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR (#124), I added a condition that allows indexer.replicaCount and searcher.replicaCount to be optional (because when you use HPA, the STS replicas field must be omitted).
However, a bug was introduced because the condition
{{- if .Values.indexer.replicaCount }}will be false when replicaCount is zero.To improve this, I am also adding the indexer.enabled flag that will help tidy things up. This works better than the
replicaCount: 0because the indexer statefulset will not be created.In summary: