Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add janitor/control plane services, cleanup. #69

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Add janitor/control plane services, cleanup. #69

merged 2 commits into from
Mar 2, 2024

Conversation

fmassot
Copy link
Contributor

@fmassot fmassot commented Mar 2, 2024 •
edited
Loading 

k get svc

NAME                                  TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)                         AGE
qw-gharchive-quickwit-control-plane   NodePort    172.20.146.158   <none>        7280:32159/TCP,7281:30186/TCP   6m56s
qw-gharchive-quickwit-headless        ClusterIP   None             <none>        7282/UDP                        6m56s
qw-gharchive-quickwit-indexer         NodePort    172.20.225.155   <none>        7280:31993/TCP,7281:32264/TCP   6m56s
qw-gharchive-quickwit-janitor         NodePort    172.20.7.94      <none>        7280:30004/TCP,7281:31495/TCP   6m56s
qw-gharchive-quickwit-metastore       NodePort    172.20.138.136   <none>        7280:31656/TCP,7281:31392/TCP   6m56s
qw-gharchive-quickwit-searcher        NodePort    172.20.126.208   <none>        7280:32179/TCP,7281:32017/TCP   6m56s

fmassot
fmassot commented Mar 2, 2024
View reviewed changes
charts/quickwit/templates/control-plane-deployment.yaml
@@ -10,7 +10,7 @@ spec:
matchLabels:
{{- include "quickwit.control_plane.selectorLabels" . | nindent 6 }}
strategy:
{{- toYaml .Values.control_plane.updateStrategy | nindent 4 }}
type: Recreate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensures only one control plane in the metastore when upgrading the chart.

fmassot
fmassot commented Mar 2, 2024
View reviewed changes
charts/quickwit/values.yaml
@@ -155,11 +155,6 @@ metastore:
# cpu: 100m
# memory: 128Mi

## Pod distruption budget
podDisruptionBudget: {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup: was not used in the chart.

fmassot
fmassot commented Mar 2, 2024
View reviewed changes
charts/quickwit/values.yaml
@@ -187,8 +182,6 @@ metastore:
affinity: {}

control_plane:
replicaCount: 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want more than 1 control plane

fmassot
fmassot commented Mar 2, 2024
View reviewed changes
charts/quickwit/values.yaml
@@ -248,14 +233,6 @@ janitor:
# cpu: 100m
# memory: 128Mi

## Pod distruption budget
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not used

@fmassot fmassot requested a review from guilload March 2, 2024 23:06
@fmassot fmassot merged commit d9f80c1 into main Mar 2, 2024
1 check passed
@fmassot fmassot deleted the fmassot/add-services branch March 2, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilload guilload guilload approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmassot @guilload