Restore rate limit metric distinction #5658
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
changed the title
|
Moving this back to draft, because this distinction is actually not bulletproof. Having made 5 persist attempts that ended up on rate limited shards we can still not conclude whether all shards were limited or not. It's still very much function of the number of shards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #5651 errors where all shards are rate limited were re-qualified from no_shards_error (503) to a rate_limiting_error (429). But rate limiting errors also cover the situation where we unfortunately tried to write to rate limited shards during all 5 workbench retries. We actually need to keep the distinction between the two for troubleshooting reasons, especially in the metrics.
How was this PR tested?
Describe how you tested this PR.