Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible solution to set the correct version in the PDF footer #836

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

thrashwerk
Copy link
Contributor

Related to !835.

Tested locally and in GH Actions on my fork.

@quii quii merged commit f3760e8 into quii:main Jan 14, 2025
1 check failed
@thrashwerk
Copy link
Contributor Author

My mistake, / is not a safe separator for sed in this case.

GITHUB_REF_NAME most likely was thrashwerk/pdf-footer-version so the sed instruction became s/%%FOOTER_VERSION%%/thrashwerk/pdf-footer-version/ which obviously isn't right.

Maybe | wouldn't cause any more conflicts.
For example

if [ -v GITHUB_REF_NAME ]; then
    sed "s|%%FOOTER_VERSION%%|${GITHUB_REF_NAME}|" meta.tmpl.tex > meta.tex
else
    sed "s|%%FOOTER_VERSION%%|UNDEFINED VERSION|" meta.tmpl.tex > meta.tex
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants