Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess columns and run types #3077

Merged

Conversation

squaregoldfish
Copy link
Collaborator

Fix #350
Fix #3076

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 17.66562% with 261 lines in your changes missing coverage. Please review.

Project coverage is 29.75%. Comparing base (ecc2da0) to head (95d205d).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...eb/Instrument/newInstrument/NewInstrumentBean.java 0.00% 75 Missing ⚠️
...e/data/Instrument/RunTypes/RunTypeAssignments.java 33.33% 68 Missing ⚠️
...p/src/uk/ac/exeter/QuinCe/data/Files/DataFile.java 6.81% 41 Missing ⚠️
...src/uk/ac/exeter/QuinCe/data/Files/DataFileDB.java 0.00% 25 Missing ⚠️
...Instrument/SensorDefinition/SensorAssignments.java 0.00% 12 Missing ⚠️
...k/ac/exeter/QuinCe/data/Instrument/Instrument.java 15.38% 11 Missing ⚠️
...a/Instrument/InstrumentCreationDateComparator.java 0.00% 5 Missing ⚠️
.../exeter/QuinCe/data/Instrument/FileDefinition.java 0.00% 4 Missing ⚠️
...Ce/data/Instrument/RunTypes/RunTypeAssignment.java 33.33% 2 Missing and 2 partials ⚠️
...k/ac/exeter/QuinCe/web/files/UploadedDataFile.java 0.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3077      +/-   ##
============================================
- Coverage     29.88%   29.75%   -0.13%     
- Complexity     2110     2113       +3     
============================================
  Files           395      396       +1     
  Lines         20511    20763     +252     
  Branches       2790     2831      +41     
============================================
+ Hits           6129     6179      +50     
- Misses        13916    14118     +202     
  Partials        466      466              
Flag Coverage Δ
unittests 29.75% <17.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squaregoldfish squaregoldfish merged commit 843ccf7 into quince-science:master Feb 12, 2025
5 of 7 checks passed
@squaregoldfish squaregoldfish deleted the 3076-auto-run-types branch February 12, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revised Run Types Pre-defined instrument types
1 participant