Make https optional

[aaron-weisberg-qz]

Motivation

• Moving to decentralized ArgoCD per cluster paradigm, we can now use and internal address to get ArgoCD diffs
• Action needs to take into account multiple diff comments for different argocd instances per commit
  • The current behavior to overwrite of existing comments causes race conditions and ultimately only a single diff gets posted
  • We also need to each diff to identity which cluster it's from

Changes

• Adds a new plaintext input which bypasses the need for a verifiable cert (which is also not setup in the new cluster)
• Adds a new environment input for customizing the diff comment title
• Posts new diff comments on each commit
  • Open to suggestions on this, but thought the need to look at old comments to get the latest diff is confusing
  • Would rather delete outdate ones and alway post a new comment

Future work

• We need to migrate away from using local diffs --local to server-side diffs since this option is being deprecated
• There are also additional performance optimizations that we should probably make before doing that though (since it causes lots of manifests generations on each PR commit on the remote argocd instances (e.x. repo-server).

Tagging

• I think we should tag master before merging just so legacy runs can easily revert
• We should also tag post merge with an upgrade so we can start locking to a tag

[rgoldfinger-quizlet]

Thanks for these improvements and I feel bad you're having to go through my old cold 😅

Would rather delete outdate ones and alway post a new comment

When implementing this I got a lot of complaints about always posting a new comment, since it spams people's email with very large messages. That's why it was moved to replacing the old comment instead.