New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cpp source include fixes #251

Open

vspinu wants to merge 3 commits into r-lib:main from vspinu:cpp_source_include

Contributor

vspinu commented Nov 23, 2021

Two improvements to srouce_cpp():

Honor <basename>_types.h or <basename>_types.hpp (I included both extensions because editor support might be different for different extensions. And I feel it's cleaner to use hpp for cpp code). Fixes How to include custom headers on top of generated cpp11.cpp? #216
Add file's directory to the include path. (addresses most common use case of How to set up CPPFLAGS with cpp11::cpp_source #246 without dealing with CPPFLAGS trickery)

vspinu added 3 commits

November 23, 2021 17:08


          [Fix r-lib#216] Include <basename>_types.h into cpp11.cpp on `source_…

36e7a98

…cpp()`


          Include file's directory into include path in source_cpp() compilation

c3be072


          cpp_source: Don't generate _N.cpp temporary suffixes in error locs

37fd5c8

vspinu mentioned this pull request

Use original path names in compiler outputs #198

Merged

Contributor Author

vspinu commented Nov 28, 2021

Re-add cleaning of _N.cpp suffixing logic originally done in #176 (4ef13b7) as per comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet