-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a list of downstream repos, and script to update #1304
Conversation
I noticed |
I guess we should also include a recommendation to add us as Suggests in the README? there's typically CRAN requirement all but it'll make things easier |
i think it's fine... not really production scripts, fine if they're a little rough around the edges |
@AshesITR PTAL. Added the e-mail templates -- these again will not be stored on GH (though the We can fine-tune the output a bit (or handle any bigger feedback), then I'll remove the temp artefacts & we can merge. After that I'll put out a call for new untracked repos. I prefer if downstreams declare themselves to us, btw, rather than getting in downstreams' hair uninvited and/or dealing with low-quality/unmaintained repos. It's also a bit more of a security risk. |
I took a glimpse now.
Also, maybe a good idea to run the checks with a soft-deprecated shim for the removed linters so we can check the remainder of the packages using now removed linters. |
Do you know what
Note that the differences are not matching on linter name, just on package/filename/line_number. So if
Not following what this would look like...
I think there's been transition enough -- as noted in the NEWS, they've been marked as deprecated already since 2017. Time to pull the plug.
great idea 👍 |
OK @AshesITR cleaned up the PR here, should be ready for merge if there are no blockers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, thanks!
Related: #1292