Skip to content

Commit

Permalink
Updated pep257 to pydocstyle and fixed a test.
Browse files Browse the repository at this point in the history
  • Loading branch information
facundobatista committed Mar 28, 2022
1 parent 8f2958f commit 62fbb3c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion fades/pipmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def _download_pip_installer(self):
os.rename(temp_location, self.pip_installer_fname)

def _brute_force_install_pip(self):
"""A brute force install of pip itself."""
"""Check a brute force install of pip itself."""
if os.path.exists(self.pip_installer_fname):
logger.debug("Using pip installer from %r", self.pip_installer_fname)
else:
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
flake8
logassert
pep257
pydocstyle
pytest
pyuca
pyxdg
Expand Down
5 changes: 2 additions & 3 deletions tests/test_infra.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from unittest.mock import patch

import docutils.core
import pep257
import pydocstyle
import rst2html5_
from flake8.api.legacy import get_style_guide
from pyuca import Collator
Expand All @@ -33,7 +33,6 @@
PEP257_ROOTS = ['fades']

# avoid seeing all DEBUG logs if the test fails
pep257.log.setLevel(logging.WARNING)
for logger_name in ('flake8.plugins', 'flake8.api', 'flake8.checker', 'flake8.main'):
logging.getLogger(logger_name).setLevel(logging.CRITICAL)

Expand All @@ -49,7 +48,7 @@ def test_flake8_pytest():

def test_pep257_pytest():
python_filepaths = get_python_filepaths(PEP257_ROOTS)
result = list(pep257.check(python_filepaths))
result = list(pydocstyle.check(python_filepaths))
assert len(result) == 0, "There are issues!\n" + '\n'.join(map(str, result))


Expand Down

0 comments on commit 62fbb3c

Please sign in to comment.