Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jarsigner to be verbose as well as including sigalg and diges… #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated jarsigner to be verbose as well as including sigalg and diges… #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/signing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,18 @@ function signAabFile(aabFile, signingKeyFile, alias, keyStorePassword, keyPasswo
const jarSignerPath = yield io.which('jarsigner', true);
core.debug(`Found 'jarsigner' @ ${jarSignerPath}`);
const args = [
'-verbose',
'-sigalg', 'SHA256withRSA',
'-digestalg', 'SHA-256',
'-keystore', signingKeyFile,
'-storepass', keyStorePassword,
];
if (keyPassword) {
args.push('-keypass', keyPassword);
}
args.push(aabFile, alias);
yield exec.exec(`"${jarSignerPath}"`, args);
const result = yield exec.exec(`"${jarSignerPath}"`, args);
core.debug(`JarSigner Result (${result}) with '${args.join(' ')}`);
return aabFile;
});
}
Expand Down
8 changes: 6 additions & 2 deletions src/signing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ export async function signAabFile(
const jarSignerPath = await io.which('jarsigner', true);
core.debug(`Found 'jarsigner' @ ${jarSignerPath}`);
const args = [
'-verbose',
'-sigalg', 'SHA256withRSA',
'-digestalg', 'SHA-256',
'-keystore', signingKeyFile,
'-storepass', keyStorePassword,
];
Expand All @@ -92,7 +95,8 @@ export async function signAabFile(

args.push(aabFile, alias);

await exec.exec(`"${jarSignerPath}"`, args);
const result = await exec.exec(`"${jarSignerPath}"`, args);
core.debug(`JarSigner Result (${result}) with '${args.join(' ')}`);

return aabFile
return aabFile;
}