-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the problem that caused installation to fail. #127
Conversation
Looks good to me. Can you apply the changes in #128 to fix CI failures?
|
Thanks for the confirmation. |
umm, looks like numpy 2.0.0 is installed on CI 🤔
|
I guess when we try to build this package using non version 2.0 numpy, we need to remove the cache in advance. |
Also, rather than specifying less than a specific version, I thought I should specify a version less than 2.0. |
I too had a problem with ci downloading numpy 2.0. I will investigate. It seems not a package requirements problem, because if we try to install nnmnkwii from the git, like |
I guess I found the reason:
so, what about removing |
By using Also, some test problems had occured, I fixed them.
And I found a error of deprecated field |
Thank you for the fixes! CI still fails on python 3.7 but I think it's OK to drop python 3.7 from CI. Shall we check all tests are passing except for python 3.7? |
I see that the test fails in 3.7. |
it works fine with me locally with python 3.8, numpy 1.24.3, OSX. I needed 907162e for tests on OSX but everything else was OK with this PR. |
Testing other versions/platforms with github actions (#128) and it is working OK too. I'll merge this PR after all CI gets green by either
|
…numpy-version # Conflicts: # pyproject.toml # setup.py
I have merged the changes of including dropping python 3.7 from ci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thank you for valuable opportunity. |
What
Fix #126
Why
The problem was due to an unset version limit for numpy.
With the release of version 2.0.0 on the 16th of this month, which contained some destructive changes, the build of this package was failing.
By setting the upper version limit, the build will succeed.
Tasks