Make it hard to accidentally enable an experimental feature flag (backport #11998) #12058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit d9819bc)
(cherry picked from commit 58e0c16)
Plus, a slightly more scary error message (cherry picked from commit e3302f2)
Also, remove the `undef` case which was only needed for RabbitMQ 3.7 and older. (cherry picked from commit ddb117f)
(cherry picked from commit 396ad7a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's easy to enable an experimental feature flag like
khepri_dbby accident. Given the operation is irreversible, this leads to serious consequences when done in a production environment.This PR implements the following changes:
rabbitmqctl enable_feature_flag khepri_dbwon't work unless a new flag--experimentalis providedThis is an automatic backport of pull request #11998 done by [Mergify](https://mergify.com).