Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Direct Reply-To #13138

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Simplify Direct Reply-To #13138

merged 1 commit into from
Jan 24, 2025

Conversation

ansd
Copy link
Member

@ansd ansd commented Jan 23, 2025

This commit is no change in functionality and mostly deletes dead code.

  1. Code targeting Erlang 22 and below is deleted since the mininmum required Erlang version is higher nowadays. "In OTP 23 distribution flag DFLAG_BIG_CREATION became mandatory. All pids are now encoded using NEW_PID_EXT, even external pids received as PID_EXT from older nodes." https://www.erlang.org/doc/apps/erts/erl_ext_dist.html#new_pid_ext
  2. All v1 encoding and decoding of the Pid is deleted since the lower version RabbitMQ node supports the v2 encoding nowadays.

@ansd ansd marked this pull request as ready for review January 23, 2025 17:55
@ansd ansd added this to the 4.1.0 milestone Jan 23, 2025
This commit is no change in functionality and mostly deletes dead code.

1. Code targeting Erlang 22 and below is deleted since the mininmum
   required Erlang version is higher nowadays.
   "In OTP 23 distribution flag DFLAG_BIG_CREATION became mandatory. All
   pids are now encoded using NEW_PID_EXT, even external pids received
   as PID_EXT from older nodes."
   https://www.erlang.org/doc/apps/erts/erl_ext_dist.html#new_pid_ext
2. All v1 encoding and decoding of the Pid is deleted since the lower
   version RabbitMQ node supports the v2 encoding nowadays.
@ansd ansd force-pushed the simplify-direct-reply-to branch from bedb8cc to 1267d59 Compare January 23, 2025 18:17
@ansd ansd requested a review from michaelklishin January 24, 2025 06:54
Copy link
Contributor

@acogoluegnes acogoluegnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran successfully direct reply-to tests from AMQP 091 Java client and JMS client.

@michaelklishin michaelklishin merged commit 4627e7a into main Jan 24, 2025
272 checks passed
@michaelklishin michaelklishin deleted the simplify-direct-reply-to branch January 24, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants